fix: reset freeze pane split positions when switching sheets (#9035) (CP: 25.0)#9045
Merged
DiegoCardoso merged 2 commits into25.0from Mar 30, 2026
Merged
Conversation
## Summary - Fixes freeze pane state bleeding between sheets when switching tabs in Spreadsheet - When switching from a sheet with a freeze pane split to one without that split type, the previous sheet's split position was not reset to 0, causing it to persist visually - Root cause: commit a1963f9 guarded `setHorizontalSplitPosition`/`setVerticalSplitPosition` behind split-exists checks but the `else` branches never explicitly reset the positions to 0 Fixes #9006 ## Test plan - [x] New unit tests in `SpreadsheetFactoryTest` verify all freeze pane combinations (both splits, only rows, only columns, none) and the sheet-switching bleed scenario - [x] Rollback verification: 3 of 5 unit tests fail without the fix, pass with it - [x] Existing regression tests (`HiddenAndFrozenIT`, `LoadFileWithFrozenPaneScrolledIT`, `MergedCellFrozenIT`) all pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
DiegoCardoso
approved these changes
Mar 30, 2026
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.0.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #9035 to branch 25.0.