fix: Do not throw exception if no IDE is found (#16058) (#16068)

Fixes #16043

Co-authored-by: Artur <artur@vaadin.com>

Author: vaadin-bot

vaadin-dev-server/src/main/java/com/vaadin/base/devserver/OpenInCurrentIde.java

@@ -164,7 +164,7 @@ static Optional<Info> findIdeCommand(List<Info> processes) {
     }
 
     private static String getCommandAndArguments(Info info) {
-        return info.commandLine().get();
+        return info.commandLine().orElse(null);
     }
 
     private static List<ProcessHandle> getParentProcesses() {
@@ -178,13 +178,16 @@ private static List<ProcessHandle> getParentProcesses() {
     }
 
     static boolean isEclipse(Info info) {
-        String lowerCase = info.command().get().toLowerCase(Locale.ENGLISH);
-        // Eclipse has a lot of other products like Temurin and Adoptium so we
-        // cannot
-        // check with "contains"
-        return lowerCase.endsWith("eclipse")
-                || lowerCase.endsWith("eclipse.exe");
+        Optional<String> cmd = info.command();
+        if (cmd.isPresent()) {
+            String lowerCmd = cmd.get().toLowerCase(Locale.ENGLISH);
+            // Eclipse has a lot of other products like Temurin and Adoptium so
+            // we cannot check with "contains"
+            return lowerCmd.endsWith("eclipse")
+                    || lowerCmd.endsWith("eclipse.exe");
+        }
 
+        return false;
     }
 
     static boolean isIdea(Info info) {
@@ -193,7 +196,8 @@ static boolean isIdea(Info info) {
 
     private static String getIdeaBinary(Info info) {
         String commandAndArguments = getCommandAndArguments(info);
-        if (commandAndArguments.contains("idea_rt.jar")) {
+        if (commandAndArguments != null
+                && commandAndArguments.contains("idea_rt.jar")) {
             String replaced = commandAndArguments
                     .replaceFirst(".*[:;]([^:;]*)(idea_rt.jar).*", "$1$2");
             if (!replaced.equals(commandAndArguments)) {
@@ -208,10 +212,7 @@ private static String getIdeaBinary(Info info) {
                 }
             }
         }
-        if (info.command().get().contains("idea")) {
-            return info.command().get();
-        }
-        return null;
+        return info.command().filter(cmd -> cmd.contains("idea")).orElse(null);
     }
 
     static boolean isVSCode(Info info) {
@@ -220,11 +221,14 @@ static boolean isVSCode(Info info) {
             return true;
         }
 
-        String cmd = getCommandAndArguments(info).toLowerCase(Locale.ENGLISH);
-        if (cmd.contains("vscode") || cmd.contains("vs code")
-                || cmd.contains("code helper")
-                || cmd.contains("visual studio code")) {
-            return true;
+        String cmd = getCommandAndArguments(info);
+        if (cmd != null) {
+            String cmdLower = cmd.toLowerCase(Locale.ENGLISH);
+            if (cmdLower.contains("vscode") || cmdLower.contains("vs code")
+                    || cmdLower.contains("code helper")
+                    || cmdLower.contains("visual studio code")) {
+                return true;
+            }
         }
 
         return false;

vaadin-dev-server/src/test/java/com/vaadin/base/devserver/OpenInCurrentIdeTest.java

@@ -528,16 +528,68 @@ public void eclipseOnLinuxDetected() {
 
     }
 
+    @Test
+    public void runFromCommandLineWorks() {
+        String cmd1 = "/opt/homebrew/Cellar/openjdk/19.0.2/libexec/openjdk.jdk/Contents/Home/bin/java";
+        String[] args1 = new String[] { "-XX:TieredStopAtLevel=1", "-Xdebug",
+                "-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5731",
+                "-cp", "lotsofjars.jar",
+                "com.example.application.Application", };
+
+        String cmd2 = "/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java";
+        String[] args2 = new String[] { "-classpath",
+                "/opt/homebrew/Cellar/maven/3.9.0/libexec/boot/plexus-classworlds-2.6.0.jar",
+                "-Dclassworlds.conf=/opt/homebrew/Cellar/maven/3.9.0/libexec/bin/m2.conf",
+                "-Dmaven.home=/opt/homebrew/Cellar/maven/3.9.0/libexec",
+                "-Dlibrary.jansi.path=/opt/homebrew/Cellar/maven/3.9.0/libexec/lib/jansi-native",
+                "-Dmaven.multiModuleProjectDirectory=/home/foo/test/openide",
+                "org.codehaus.plexus.classworlds.launcher.Launcher",
+                "spring-boot:run", };
+
+        String cmd3 = "/bin/zsh";
+        String[] args3 = new String[] {};
+
+        String cmd4 = null;
+        String[] args4 = null;
+
+        String cmd5 = "/System/Applications/Utilities/Terminal.app/Contents/MacOS/Terminal";
+        String[] args5 = new String[] {};
+
+        String cmd6 = null;
+        String[] args6 = null;
+
+        Info info1 = mock(cmd1, args1);
+        Info info2 = mock(cmd2, args2);
+        Info info3 = mock(cmd3, args3);
+        Info info4 = mock(cmd4, args4);
+        Info info5 = mock(cmd5, args5);
+        Info info6 = mock(cmd6, args6);
+
+        List<Info> processes = new ArrayList<>();
+        processes.add(info1);
+        processes.add(info2);
+        processes.add(info3);
+        processes.add(info4);
+        processes.add(info5);
+        processes.add(info6);
+
+        Optional<Info> ideCommand = OpenInCurrentIde.findIdeCommand(processes);
+        Assert.assertTrue(ideCommand.isEmpty());
+    }
+
     private Info mock(String cmd) {
         return mock(cmd, cmd);
     }
 
     private Info mock(String cmd, String[] arguments) {
         Info info = Mockito.mock(Info.class);
-        Mockito.when(info.command()).thenReturn(Optional.of(cmd));
-        Mockito.when(info.arguments()).thenReturn(Optional.of(arguments));
-        Mockito.when(info.commandLine()).thenReturn(
-                Optional.of(cmd + " " + String.join(" ", arguments)));
+        Mockito.when(info.command()).thenReturn(Optional.ofNullable(cmd));
+        Mockito.when(info.arguments())
+                .thenReturn(Optional.ofNullable(arguments));
+        if (cmd != null && arguments != null) {
+            Mockito.when(info.commandLine()).thenReturn(
+                    Optional.of(cmd + " " + String.join(" ", arguments)));
+        }
 
         return info;
     }