feat: bundle should take into account index.ts (#15893) (#15895)

* feat: bundle should take into account index.ts

Require rebundling for changes in
frontend/index.ts file.

Fixes #15883

* Update flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunDevBundleBuild.java



---------

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

Author: 3 people

flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunDevBundleBuild.java

@@ -249,7 +249,8 @@ private static boolean packagedThemeAddedOrUpdated(Options options,
 
     private static boolean frontendImportsFound(JsonObject statsJson,
             Options options, ClassFinder finder,
-            FrontendDependenciesScanner frontendDependencies) {
+            FrontendDependenciesScanner frontendDependencies)
+            throws IOException {
 
         // Validate frontend requirements in flow-generated-imports.js
         final GenerateMainImports generateMainImports = new GenerateMainImports(
@@ -313,6 +314,25 @@ private static boolean frontendImportsFound(JsonObject statsJson,
                     faulty.toString());
             return false;
         }
+
+        File indexTs = new File(options.getFrontendDirectory(),
+                FrontendUtils.INDEX_TS);
+        if (indexTs.exists()) {
+            if (!frontendHashes.hasKey(FrontendUtils.INDEX_TS)) {
+                return false;
+            }
+            String content = FileUtils
+                    .readFileToString(indexTs, StandardCharsets.UTF_8)
+                    .replaceAll("\\r\\n", "\n");
+            final String contentHash = StringUtil.getHash(content,
+                    StandardCharsets.UTF_8);
+            if (!frontendHashes.getString(FrontendUtils.INDEX_TS)
+                    .equals(contentHash)) {
+                getLogger().info("'index.ts' is not up to date");
+                return false;
+            }
+        }
+
         return true;
     }
 

flow-server/src/main/resources/vite.generated.ts

@@ -223,6 +223,13 @@ function statsExtracterPlugin(): PluginOption {
         // @ts-ignore
         frontendFiles[`${fileKey}`] = hash;
       });
+      // If a index.ts exists hash it to be able to see if it changes.
+      if (existsSync(path.resolve(frontendFolder, "index.ts"))) {
+        const fileBuffer = readFileSync(path.resolve(frontendFolder, "index.ts"), {encoding: 'utf-8'}).replace(/\r\n/g, '\n');
+        const hash = createHash('sha256').update(fileBuffer, 'utf8').digest("hex");
+        // @ts-ignore
+        frontendFiles[`index.ts`] = hash;
+      }
 
       const themeJsonHashes = { };
       const themesFolder = path.resolve(jarResourcesFolder, "themes");

flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskRunDevBundleBuildTest.java

@@ -1093,6 +1093,49 @@ public void reusedTheme_previouslyAddedThemes_noUpdates_noBundleRebuild()
         }
     }
 
+    @Test
+    public void changeInIndexTs_rebuildRequired() throws IOException {
+        createPackageJsonStub("{\"dependencies\": {}, "
+                + "\"vaadin\": { \"hash\": \"aHash\"} }");
+        File frontendFolder = temporaryFolder.newFolder(FrontendUtils.FRONTEND);
+
+        File indexTs = new File(frontendFolder, FrontendUtils.INDEX_TS);
+        indexTs.createNewFile();
+
+        FileUtils.write(indexTs, "window.alert('');", StandardCharsets.UTF_8);
+
+        final FrontendDependenciesScanner depScanner = Mockito
+                .mock(FrontendDependenciesScanner.class);
+
+        JsonObject stats = getBasicStats();
+        stats.getObject(FRONTEND_HASHES).put(FrontendUtils.INDEX_TS,
+                "15931fa8c20e3c060c8ea491831e95cc8463962700a9bfb82c8e3844cf608f04");
+
+        try (MockedStatic<FrontendUtils> utils = Mockito
+                .mockStatic(FrontendUtils.class)) {
+            utils.when(() -> FrontendUtils.getDevBundleFolder(Mockito.any()))
+                    .thenReturn(temporaryFolder.getRoot());
+            utils.when(() -> FrontendUtils
+                    .findBundleStatsJson(temporaryFolder.getRoot()))
+                    .thenReturn(stats.toJson());
+
+            boolean needsBuild = TaskRunDevBundleBuild
+                    .needsBuildInternal(options, depScanner, finder);
+            Assert.assertFalse(
+                    "'index.ts' equal content should not require bundling",
+                    needsBuild);
+
+            FileUtils.write(indexTs, "window.alert('hello');",
+                    StandardCharsets.UTF_8);
+
+            needsBuild = TaskRunDevBundleBuild.needsBuildInternal(options,
+                    depScanner, finder);
+            Assert.assertTrue(
+                    "changed content for 'index.ts' should require bundling",
+                    needsBuild);
+        }
+    }
+
     private void createPackageJsonStub(String content) throws IOException {
         File packageJson = new File(temporaryFolder.getRoot(),
                 Constants.PACKAGE_JSON);