Update to POI 3.17 release#617
Conversation
* only measureValueWidth if column width is greater than 0 * Consider hidden rows and cols in getRealEventTargetCell * Prevent NPE with links without address
Selecting a cell via single-clicking or via arrow keys, entering a value by typing, and then using the arrow keys again saves the new value and moves to the appropriate adjacent cell. When editing a cell with double-click or with F2, arrow keys still behave as they used to: move inside the cell value editor. Fixes #598, #246.
Removed @ignore on tests that should be working in this version of POI.
|
|
|
I waited too long, and can no longer see which tests are failing in TeamCity. Can someone send me the last build log or run another one? I'm finally freeing some cycles from our product release to work on this. I have more contributions, including Excel theme and table style support, but they need this integrated first. Also, the failures are unexpected, and I'm concerned a bug may have crept into POI 3.17 between the last beta and release. |
|
These three failures appear to be due to some bugs in my POI conditional formatting evaluation. Thanks for the unit tests, I've used them to find and fix the issues. Unfortunately the fix is in POI trunk, with the next release being 4.0 with all the deprecated code removed. I was out of the country for some of the early discussions on other changes, but I think it is mostly new things and clean-up. Haven't checked to see if Vaadin Spreadsheet still compiles with a current snapshot build. POI bugs I found and fixed for these tests: 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types Both are deep enough I couldn't find a workaround usable on the Vaadin side as a temporary fix. I'll leave it to you folks what you want to do about these. They could be commented out and the bugs lived with for now, or the plan could change to waiting for 4.0, or something else I can't think of this late. |
After update POI to 3.17 there is some regression in the following tests: ConditionalFormattingBasedOnFormulaTest.loadSpreadsheetWithConditionalFormattingRulesInRow10_EvaluateFormatting_CheckColorOfCells ConditionalFormattingBasedOnSharedFormulaTest.loadSpreadsheetWithConditionalFormattingInA1A2_A3B4_D1G5___CheckCellFormatting ConditionalFormattingCellValueIsTest.loadSpreadsheetWithNotEqualConditionFormattingInB4_insertIncoherentValue_CellB4FilledRed
|
Reviewed 4 of 5 files at r1, 3 of 3 files at r2, 4 of 4 files at r3, 1 of 1 files at r4, 5 of 5 files at r5, 3 of 3 files at r6. Comments from Reviewable |
6 participants
This change is