show in the formula bar only those named ranges that can be selected#627
Merged
show in the formula bar only those named ranges that can be selected#627
Conversation
added 2 commits
November 1, 2017 15:53
Some named ranges are not-selectable (e.g. referring to a non-continuous area, or to a formula). MS Excel does not show them in the formula bar named ranges selector. This PR changes the Spreadsheet behavior accordingly. Incorporates the PR #622 by @ianscriven (fixes #621). Fixes the issue that when a user attempted to select a non-selectable named range it did not get selected. Contains a workaround for the POI issue https://bz.apache.org/bugzilla/show_bug.cgi?id=61701 that causes IllegalArgumentException when trying to select a named range referring to some formulas. (cherry-picked from 246eeeb from the 1.4 branch) Jira: SHEET-338
after cherry-picking from the 1.4 branch the FF screenshot should be updated to FF45, and the IE10 screenshot should be removed
Contributor
Author
|
Reviewed 11 of 11 files at r1. Comments from Reviewable |
Closed
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Apr 27, 2022
vaadin/spreadsheet#627 Some named ranges are not-selectable (e.g. referring to a non-continuous area, or to a formula). MS Excel does not show them in the formula bar named ranges selector. This PR changes the Spreadsheet behavior accordingly. Incorporates the PRvaadin/spreadsheet#622 by @ianscriven (Fixes: vaadin/spreadsheet#621). Fixes the issue that when a user attempted to select a non-selectable named range it did not get selected. Contains a workaround for the POI issue https://bz.apache.org/bugzilla/show_bug.cgi?id=61701 that causes IllegalArgumentException when trying to select a named range referring to some formulas. (cherry-picked from 246eeeb from the 1.4 branch + updated the reference screenshot to work in the 2.x branch) Jira: SHEET-338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some named ranges are not-selectable (e.g. referring to a non-continuous area, or to a formula). MS Excel does not show them in the formula bar named ranges selector. This PR changes the Spreadsheet behavior accordingly.
Incorporates the PR #622 by @ianscriven (fixes #621).
Fixes the issue that when a user attempted to select a non-selectable named range it did not get selected.
Contains a workaround for the POI issue https://bz.apache.org/bugzilla/show_bug.cgi?id=61701 that causes IllegalArgumentException when trying to select a named range referring to some formulas.
(cherry-picked from 246eeeb from the 1.4 branch)
Jira: SHEET-338
This change is