Delay and avoid expensive createCellDataForCell#714
Merged
alvarezguille merged 2 commits intomasterfrom Mar 12, 2020
Merged
Conversation
Computing cell data shouldn't be done for all rows as it has a big performance impact With this change cell data is only created for sent cells and formulas This change doesn't prevent the large json in some responses, but it does prevent the extensive computing time on server-side which was causing the 5 minutes time to first byte for the server request. Fixes #713
tulioag
approved these changes
Mar 11, 2020
Contributor
tulioag
left a comment
tulioag
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
alvarezguille
commented
Mar 12, 2020
Member
Author
alvarezguille
left a comment
alvarezguille
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
alvarezguille
commented
Mar 12, 2020
Member
Author
alvarezguille
left a comment
alvarezguille
left a comment
There was a problem hiding this comment.
Reviewable status:
alvarezguille
deleted the
fix/713-improve-updateMarkedCellValues-performance
branch
alvarezguille
added a commit
that referenced
this pull request
Apr 16, 2020
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Apr 27, 2022
vaadin/spreadsheet#714 Computing cell data shouldn't be done for all rows as it has a big performance impact With this change cell data is only created for sent cells and formulas This change doesn't prevent the large json in some responses, but it does prevent the extensive computing time on server-side which was causing the 5 minutes time to first byte for the server request. Fixes: vaadin/spreadsheet#713 Mark cells with formatting rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computing cell data shouldn't be done for all rows as it has a big
performance impact
With this change cell data is only created for sent cells and formulas
This change doesn't prevent the large json in some responses, but it
does prevent the extensive computing time on server-side which was
causing the 5 minutes time to first byte (TTFB) for the server request.
Fixes #713
This change is