Skip to content

feat: log all exceptions caught by RetryRule#1663

Merged
mshabarov merged 2 commits into
mainfrom
feat/retry_rule_original_exception
Aug 21, 2023
Merged

feat: log all exceptions caught by RetryRule#1663
mshabarov merged 2 commits into
mainfrom
feat/retry_rule_original_exception

Conversation

@mcollovati

Copy link
Copy Markdown
Contributor

Description

Currently, RetryRule show details only of the last caught exception, but this one may not be the real reason of the test failure. This change prints the stack trace of all caught expections when debug level for RetryRule is at least 'debug', helping the develper to detect the real cause of the test failure.

Fixes #1527

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Currently, RetryRule show details only of the last caught exception, but this
one may not be the real reason of the test failure.
This change prints the stack trace of all caught expections when debug level
for RetryRule is at least 'debug', helping the develper to detect the real
cause of the test failure.

Fixes #1527
@mshabarov mshabarov self-requested a review August 14, 2023 11:11
@mshabarov mshabarov enabled auto-merge (squash) August 21, 2023 11:46
@mshabarov mshabarov merged commit d185ae4 into main Aug 21, 2023
@mshabarov mshabarov deleted the feat/retry_rule_original_exception branch August 21, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect error messages from all caught exceptions in RetryRule

2 participants