Skip to content

Conversation

@TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Nov 18, 2025

Fixes

java.io.NotSerializableException: com.vaadin.testbench.unit.BaseUIUnitTest$$Lambda$2828/0x0000755804ecbf70
	at java.base/java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1187)
	at java.base/java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1572)
	at java.base/java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1529)
	at java.base/java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1438)

Which is cased by

java.io.NotSerializableException: com.vaadin.testbench.unit.BaseUIUnitTest$$Lambda/0x00007414ec76b3a0
	- field (class "com.vaadin.testbench.unit.internal.MockVaadinKt$sam$com_vaadin_testbench_unit_internal_UIFactory$0", name: "function", type: "interface kotlin.jvm.functions.Function0")
	- object (class "com.vaadin.testbench.unit.internal.MockVaadinKt$sam$com_vaadin_testbench_unit_internal_UIFactory$0", com.vaadin.testbench.unit.internal.MockVaadinKt$sam$com_vaadin_testbench_unit_internal_UIFactory$0@672173b6)
	- field (class "com.vaadin.testbench.unit.internal.MockPage", name: "uiFactory", type: "interface com.vaadin.testbench.unit.internal.UIFactory")
	- object (class "com.vaadin.testbench.unit.internal.MockPage", com.vaadin.testbench.unit.internal.MockPage@2ce0f0b9)
	- field (class "com.vaadin.flow.component.UI", name: "page", type: "class com.vaadin.flow.component.page.Page")
	- object (class "com.vaadin.testbench.unit.mocks.MockedUI", com.vaadin.testbench.unit.mocks.MockedUI@6c7a9a0b)

Which again happens because not all methods in MockVaadin.kt has defined UIFactory as parameter, but some use () -> UI.

vaadin/kubernetes-kit#187

Removed VaadinSession from serialization test.
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Test Results

  167 files  +11    167 suites  +11   31m 39s ⏱️ - 21m 20s
1 153 tests + 2  1 147 ✅ + 3  6 💤 ±0  0 ❌ ±0 
1 604 runs  +83  1 595 ✅ +81  9 💤 +3  0 ❌ ±0 

Results for commit 026b0af. ± Comparison against base commit e706e66.

♻️ This comment has been updated with latest results.

@TatuLund TatuLund changed the title fix: Implement Serializable in ComponentTester class fix: Fix serialization issues in creation of Vaadin mocks Nov 18, 2025
@TatuLund TatuLund merged commit 4bba6bb into main Nov 20, 2025
4 checks passed
@TatuLund TatuLund deleted the tester-serializable branch November 20, 2025 08:03
@vaadin-bot
Copy link
Collaborator

Hi @TatuLund and @TatuLund, when i performed cherry-pick to this commit to 9.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4bba6bb
error: could not apply 4bba6bb... fix: Fix serialization issues in creation of Vaadin mocks (#2082)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants