-
Notifications
You must be signed in to change notification settings - Fork 23
fix: Fix serialization issues in creation of Vaadin mocks #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a test to verify that Vaadin session is serializable.
Removed VaadinSession from serialization test.
Removed unused import for Function0 from Kotlin.
...n-testbench-unit-shared/src/main/java/com/vaadin/testbench/unit/mocks/MockSpringServlet.java
Outdated
Show resolved
Hide resolved
...ench-unit-shared/src/main/java/com/vaadin/testbench/unit/mocks/MockSpringServletService.java
Outdated
Show resolved
Hide resolved
...bench-unit-shared/src/main/java/com/vaadin/testbench/unit/mocks/MockSpringVaadinSession.java
Outdated
Show resolved
Hide resolved
vaadin-testbench-unit-shared/src/main/java/com/vaadin/testbench/unit/ComponentTester.java
Outdated
Show resolved
Hide resolved
...in-testbench-unit-shared/src/main/java/com/vaadin/testbench/unit/SerializationDebugUtil.java
Outdated
Show resolved
Hide resolved
...in-testbench-unit-shared/src/main/java/com/vaadin/testbench/unit/SerializationDebugUtil.java
Show resolved
Hide resolved
vaadin-testbench-unit-shared/src/main/kotlin/com/vaadin/testbench/unit/internal/MockVaadin.kt
Outdated
Show resolved
Hide resolved
vaadin-testbench-unit/src/test/java/com/vaadin/testbench/unit/ComponentTesterTest.java
Outdated
Show resolved
Hide resolved
...in-testbench-unit-shared/src/main/java/com/vaadin/testbench/unit/SerializationDebugUtil.java
Show resolved
Hide resolved
|
Hi @TatuLund and @TatuLund, when i performed cherry-pick to this commit to 9.5, i have encountered the following issue. Can you take a look and pick it manually? |
Fixes
Which is cased by
Which again happens because not all methods in MockVaadin.kt has defined UIFactory as parameter, but some use () -> UI.
vaadin/kubernetes-kit#187