feat: Set up new OSS browserless-test module structure#2139
Merged
Conversation
Add Apache 2.0 license header template, parent aggregator POM, and child POM files for three new open-source browserless test modules under browserless-test/: - browserless-test/shared - browserless-test/junit6 - browserless-test/quarkus Include duplicates of eclipse formatter config and import order files so the browserless-test directory can be extracted as a standalone project with working spotless configuration. Register the parent module in root POM and add child artifacts to the testbench BOM. No source code yet.
Removed deprecated OSS browserless test modules from pom.xml.
mcollovati
requested changes
Feb 24, 2026
Contributor
mcollovati
left a comment
mcollovati
left a comment
There was a problem hiding this comment.
nit: use properties for both plugins and dependencies versions.
Also, it would be good to manage plugin's versions in the browserless parent POM
mcollovati
reviewed
Feb 24, 2026
Update dependency versions (slf4j 2.0.17, surefire/failsafe 3.5.5, spotless 3.2.1), add url to parent POM and remove from submodules, fix browserless-test-bom version to 1.0-SNAPSHOT in testbench BOM, and centralize all plugin versions in parent pluginManagement.
mcollovati
requested changes
Feb 24, 2026
Contributor
mcollovati
left a comment
mcollovati
left a comment
There was a problem hiding this comment.
I think another couple of XML tags can be moved to the browserless parent POM, to make other POMs cleaner:
- inceptionYear (currently there are different values, e.g. 2022 and 2024, but I guess we can have a single one)
- repositories
- license
Perhaps there are other minor cleanups that could also be done, but can be done later.
Consolidate common XML tags in the browserless-test parent POM and remove duplicates from submodules to keep child POMs cleaner.
Member
Author
|
updated |
mcollovati
reviewed
Feb 24, 2026
Change the BOM parent from browserless-test to vaadin-parent so it is independent from the aggregator POM, consistent with how Flow handles its BOM.
Move bom to end of modules list and add spotless plugin with skip so Maven can resolve the spotless prefix in the reactor build.
mcollovati
approved these changes
Feb 24, 2026
Artur-
added a commit
that referenced
this pull request
Feb 24, 2026
Add Apache 2.0 license header template, parent aggregator POM, and child POM files for three new open-source browserless test modules under browserless-test/: - browserless-test/bom - browserless-test/shared - browserless-test/junit6 - browserless-test/quarkus Include duplicates of eclipse formatter config and import order files so the browserless-test directory can be extracted as a standalone project with working spotless configuration. Register the parent module in root POM. No source code yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Apache 2.0 license header template, parent aggregator POM, and child POM files for three new open-source browserless test modules under browserless-test/:
Include duplicates of eclipse formatter config and import order files so the browserless-test directory can be extracted as a standalone project with working spotless configuration.
Register the parent module in root POM and add child artifacts to the testbench BOM. No source code yet.