Skip to content

Commit 698379c

Browse files
web-padawanclaude
andauthored
test: add padding to custom-field Lumo visual test fixtures (#11467)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent a24d6d7 commit 698379c

18 files changed

Lines changed: 54 additions & 43 deletions

packages/custom-field/test/visual/lumo/custom-field.test.js

Lines changed: 54 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -29,60 +29,67 @@ import '../../../vaadin-custom-field.js';
2929

3030
describe('custom-field', () => {
3131
describe('basic', () => {
32-
let element, inputs;
32+
let div, element, inputs;
3333

3434
beforeEach(() => {
35-
element = fixtureSync(`
35+
div = document.createElement('div');
36+
div.style.display = 'inline-block';
37+
div.style.padding = '10px';
38+
39+
element = fixtureSync(
40+
`
3641
<vaadin-custom-field>
3742
<input type="text" />
3843
<input type="number" />
3944
</vaadin-custom-field>
40-
`);
45+
`,
46+
div,
47+
);
4148
inputs = element.querySelectorAll('input');
4249
});
4350

4451
it('basic', async () => {
45-
await visualDiff(element, 'basic-default');
52+
await visualDiff(div, 'basic-default');
4653
});
4754

4855
it('label', async () => {
4956
element.label = 'Home address';
50-
await visualDiff(element, 'basic-label');
57+
await visualDiff(div, 'basic-label');
5158
});
5259

5360
it('value', async () => {
5461
element.label = 'Home address';
5562
inputs[0].value = 'Foo street';
5663
inputs[1].value = 42;
57-
await visualDiff(element, 'basic-value');
64+
await visualDiff(div, 'basic-value');
5865
});
5966

6067
it('disabled', async () => {
6168
element.disabled = true;
6269
inputs[0].disabled = true;
6370
inputs[1].disabled = true;
64-
await visualDiff(element, 'basic-disabled');
71+
await visualDiff(div, 'basic-disabled');
6572
});
6673

6774
it('required', async () => {
6875
element.label = 'Home address';
6976
element.required = true;
70-
await visualDiff(element, 'basic-required');
77+
await visualDiff(div, 'basic-required');
7178
});
7279

7380
it('invalid', async () => {
7481
element.label = 'Home address';
7582
element.required = true;
7683
element.invalid = true;
77-
await visualDiff(element, 'basic-invalid');
84+
await visualDiff(div, 'basic-invalid');
7885
});
7986

8087
it('error message', async () => {
8188
element.label = 'Home address';
8289
element.required = true;
8390
element.errorMessage = 'foo';
8491
element.invalid = true;
85-
await visualDiff(element, 'basic-error-message');
92+
await visualDiff(div, 'basic-error-message');
8693
});
8794

8895
it('disabled required', async () => {
@@ -91,12 +98,12 @@ describe('custom-field', () => {
9198
element.disabled = true;
9299
inputs[0].disabled = true;
93100
inputs[1].disabled = true;
94-
await visualDiff(element, 'basic-disabled-required');
101+
await visualDiff(div, 'basic-disabled-required');
95102
});
96103

97104
it('helper text', async () => {
98105
element.helperText = 'Helper text';
99-
await visualDiff(element, 'basic-helper-text');
106+
await visualDiff(div, 'basic-helper-text');
100107
});
101108

102109
it('helper above field', async () => {
@@ -106,15 +113,15 @@ describe('custom-field', () => {
106113
element.validate();
107114
element.helperText = 'Helper text';
108115
element.setAttribute('theme', 'helper-above-field');
109-
await visualDiff(element, 'helper-above-field');
116+
await visualDiff(div, 'helper-above-field');
110117
});
111118

112119
it('theme-whitespace', async () => {
113120
element.setAttribute('theme', 'whitespace');
114121
element.label = 'Label';
115122
inputs[0].style.display = 'block';
116123
inputs[1].style.display = 'none';
117-
await visualDiff(element, 'whitespace-theme');
124+
await visualDiff(div, 'whitespace-theme');
118125
});
119126
});
120127

@@ -124,7 +131,7 @@ describe('custom-field', () => {
124131
describe('error message', () => {
125132
beforeEach(() => {
126133
wrapper = fixtureSync(`
127-
<div>
134+
<div style="padding: 10px">
128135
<vaadin-custom-field invalid error-message="Invalid">
129136
<vaadin-number-field value="1"></vaadin-number-field>
130137
<vaadin-password-field value="password"></vaadin-password-field>
@@ -143,7 +150,7 @@ describe('custom-field', () => {
143150
describe('label', () => {
144151
beforeEach(() => {
145152
wrapper = fixtureSync(`
146-
<div>
153+
<div style="padding: 10px">
147154
<vaadin-custom-field label="Custom field">
148155
<vaadin-select
149156
value="+358"
@@ -169,7 +176,7 @@ describe('custom-field', () => {
169176
describe('label + error message', () => {
170177
beforeEach(() => {
171178
wrapper = fixtureSync(`
172-
<div>
179+
<div style="padding: 10px">
173180
<vaadin-custom-field label="Custom field" invalid error-message="Invalid">
174181
<vaadin-email-field value="user@example.com"></vaadin-email-field>
175182
<vaadin-date-picker value="1980-08-14" clear-button-visible></vaadin-date-picker>
@@ -188,7 +195,7 @@ describe('custom-field', () => {
188195
describe('label + helper text', () => {
189196
beforeEach(() => {
190197
wrapper = fixtureSync(`
191-
<div>
198+
<div style="padding: 10px">
192199
<vaadin-custom-field label="Custom field" helper-text="Helper">
193200
<vaadin-combo-box value="Combo item" allow-custom-value clear-button-visible></vaadin-combo-box>
194201
<vaadin-time-picker value="09:00"></vaadin-time-picker>
@@ -206,47 +213,51 @@ describe('custom-field', () => {
206213
});
207214

208215
describe('form-layout', () => {
209-
let layout;
216+
let wrapper;
210217

211218
describe('label + error message', () => {
212219
beforeEach(() => {
213-
layout = fixtureSync(`
214-
<vaadin-form-layout style="width: 60em">
215-
<vaadin-text-field label="Text field" invalid error-message="Error"></vaadin-text-field>
216-
<vaadin-custom-field label="Custom field" invalid error-message="Error">
217-
<vaadin-text-field></vaadin-text-field>
218-
</vaadin-custom-field>
219-
</vaadin-form-layout>
220+
wrapper = fixtureSync(`
221+
<div style="padding: 10px">
222+
<vaadin-form-layout style="width: 60em">
223+
<vaadin-text-field label="Text field" invalid error-message="Error"></vaadin-text-field>
224+
<vaadin-custom-field label="Custom field" invalid error-message="Error">
225+
<vaadin-text-field></vaadin-text-field>
226+
</vaadin-custom-field>
227+
</vaadin-form-layout>
228+
</div>
220229
`);
221230
});
222231

223232
it('label in form layout', async () => {
224-
await visualDiff(layout, 'form-layout-label-error-message');
233+
await visualDiff(wrapper, 'form-layout-label-error-message');
225234
});
226235
});
227236

228237
describe('form-item', () => {
229238
beforeEach(() => {
230-
layout = fixtureSync(`
231-
<vaadin-form-layout style="width: 60em">
232-
<vaadin-form-item>
233-
<label slot="label">Custom field with text area</label>
234-
<vaadin-custom-field>
235-
<vaadin-text-area
236-
value="Sed libero enim, sed faucibus turpis in eu? Euismod lacinia at quis risus sed vulputate odio ut enim blandit volutpat maecenas volutpat blandit aliquam etiam erat velit, scelerisque in dictum!"
237-
></vaadin-text-area>
238-
</vaadin-custom-field>
239-
</vaadin-form-item>
240-
<vaadin-form-item>
241-
<label slot="label">Text field</label>
242-
<vaadin-text-field></vaadin-text-field>
243-
</vaadin-form-item>
244-
</vaadin-form-layout>
239+
wrapper = fixtureSync(`
240+
<div style="padding: 10px">
241+
<vaadin-form-layout style="width: 60em">
242+
<vaadin-form-item>
243+
<label slot="label">Custom field with text area</label>
244+
<vaadin-custom-field>
245+
<vaadin-text-area
246+
value="Sed libero enim, sed faucibus turpis in eu? Euismod lacinia at quis risus sed vulputate odio ut enim blandit volutpat maecenas volutpat blandit aliquam etiam erat velit, scelerisque in dictum!"
247+
></vaadin-text-area>
248+
</vaadin-custom-field>
249+
</vaadin-form-item>
250+
<vaadin-form-item>
251+
<label slot="label">Text field</label>
252+
<vaadin-text-field></vaadin-text-field>
253+
</vaadin-form-item>
254+
</vaadin-form-layout>
255+
</div>
245256
`);
246257
});
247258

248259
it('label in form layout', async () => {
249-
await visualDiff(layout, 'form-layout-item-text-area');
260+
await visualDiff(wrapper, 'form-layout-item-text-area');
250261
});
251262
});
252263
});
129 Bytes
Loading
8 Bytes
Loading
-6 Bytes
Loading
-62 Bytes
Loading
72 Bytes
Loading
43 Bytes
Loading
81 Bytes
Loading
68 Bytes
Loading
72 Bytes
Loading

0 commit comments

Comments
 (0)