test: add padding to custom-field Lumo visual test fixtures#11467
Merged
web-padawan merged 1 commit intomainfrom Apr 9, 2026
Merged
test: add padding to custom-field Lumo visual test fixtures#11467web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
Wrap all custom-field Lumo visual test fixtures in a padded div to prevent Playwright's default cursor position at (0,0) from triggering :hover styles on the component. This caused label and helper text to render in hover color (--lumo-body-text-color) instead of default (--lumo-secondary-text-color). All other Lumo field component tests already use this pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
changed the title
|
3 tasks
vursen
approved these changes
Apr 9, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
added a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padding: 10px) to prevent Playwright's default cursor position at (0,0) from triggering:hoverstyles on the component--lumo-body-text-color/ 90% contrast) instead of default (--lumo-secondary-text-color/ 70% contrast)Test plan
yarn test:lumo --group custom-fieldpasses in Docker🤖 Generated with Claude Code