Skip to content

Conversation

@web-padawan
Copy link
Member

@web-padawan web-padawan commented Oct 14, 2025

Description

Upgraded Playwright to 1.56.0 and skipped some tests that fail in WebKit 26.
The reason is that you can't type 1-- anymore in the latest Safari - Apple says no.

Type of change

  • Internal change

Note

Added target/24.9 label to backport this as we agreed in the past to backport Playwright bumps.
Let's keep 24.8 branch for now using the older version of Playwright just in case.

@web-padawan web-padawan force-pushed the chore/bump-playwright-1.56 branch from 1d26304 to 53af6ea Compare October 16, 2025 12:01
@sonarqubecloud
Copy link

@web-padawan web-padawan removed the request for review from sissbruecker October 17, 2025 07:33
@web-padawan web-padawan merged commit 2218528 into main Oct 17, 2025
11 of 12 checks passed
@web-padawan web-padawan deleted the chore/bump-playwright-1.56 branch October 17, 2025 07:34
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2218528
error: could not apply 2218528... chore: upgrade Playwright version to 1.56.0 (#10324)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants