-
Notifications
You must be signed in to change notification settings - Fork 88
fix: prevent opening overlay or selecting item if modifier key is used #10508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent opening overlay or selecting item if modifier key is used #10508
Conversation
|
|
Hi @ugur-vaadin and @web-padawan, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually? |
|
Hi @ugur-vaadin and @web-padawan, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually? |
|
I’m curious: why did we exclude the Shift key as well? |
This was just a copy-paste, IMO in such cases like this one it's ok to exclude it as we don't handle e.g. Tab here. |
|
This ticket/PR has been released with Vaadin 25.0.0-beta6. |



Description
This PR adds extra checks for modifier keys so that no item gets selected while using a shortcut.
Fixes #10505
Type of change
Checklist