Skip to content

Conversation

@ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Nov 17, 2025

Description

This PR adds extra checks for modifier keys so that no item gets selected while using a shortcut.

Fixes #10505

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud
Copy link

@web-padawan web-padawan changed the title fix: do not select item when modifier key is used fix: prevent opening overlay or selecting item if modifier key is used Nov 18, 2025
@web-padawan web-padawan removed the request for review from DiegoCardoso November 18, 2025 09:10
@web-padawan web-padawan merged commit 8a4d0ea into main Nov 18, 2025
9 checks passed
@web-padawan web-padawan deleted the fix-do-not-select-item-when-modifier-key-is-used branch November 18, 2025 09:11
@vaadin-bot
Copy link
Collaborator

Hi @ugur-vaadin and @web-padawan, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8a4d0ea
error: could not apply 8a4d0ea... fix: prevent opening or selecting item if modifier key is used (#10508)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @ugur-vaadin and @web-padawan, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8a4d0ea
error: could not apply 8a4d0ea... fix: prevent opening or selecting item if modifier key is used (#10508)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@jouni
Copy link
Member

jouni commented Nov 18, 2025

I’m curious: why did we exclude the Shift key as well?

@web-padawan
Copy link
Member

why did we exclude the Shift key as well?

This was just a copy-paste, IMO in such cases like this one it's ok to exclude it as we don't handle e.g. Tab here.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-beta6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vaadin-select] Selecting by first letter does not check modifier keys

5 participants