fix: make scrollToColumn update cell position synchronously#11291
Merged
sissbruecker merged 1 commit intomainfrom Mar 10, 2026
Merged
fix: make scrollToColumn update cell position synchronously#11291sissbruecker merged 1 commit intomainfrom
sissbruecker merged 1 commit intomainfrom
Conversation
|
tomivirkki
approved these changes
Mar 10, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-beta3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any scrolling in the grid needs to run
__updateHorizontalScrollPositionto update positions of individual table elements so that the respective content actually becomes visible. Currently this is only run asynchronously afterscrollToColumn, which means that scrolling to a column programmatically in a test can lead to follow up interactions (e.g. clicks) with cell contents failing (similar issue with checking cell visibility in the currently flaky flow-components ITs).This change calls
__updateHorizontalScrollPositionsynchronously inscrollToColumn, so content can be interacted with right after scrolling.Type of change