Skip to content

fix: only show focus ring in MDL overlay when keyboard is active#11451

Merged
web-padawan merged 1 commit intomainfrom
fix/mdl-focus-visible
Apr 7, 2026
Merged

fix: only show focus ring in MDL overlay when keyboard is active#11451
web-padawan merged 1 commit intomainfrom
fix/mdl-focus-visible

Conversation

@web-padawan
Copy link
Copy Markdown
Member

Summary

  • Use isKeyboardActive() to conditionally pass focusVisible when focusing detail content on overlay open
  • Prevents unwanted visible focus outlines when the detail panel is opened via mouse interaction
  • Adds tests covering preventScroll and focusVisible behavior for keyboard and mouse scenarios

Test plan

  • yarn test --group master-detail-layout — all new tests pass
  • Manual: open detail via mouse click → no focus ring visible
  • Manual: open detail via keyboard → focus ring visible

🤖 Generated with Claude Code

Use isKeyboardActive() to conditionally set focusVisible when focusing
the detail content on overlay open, preventing unwanted focus outlines
on mouse-triggered interactions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@web-padawan web-padawan requested review from jouni and vursen April 7, 2026 12:25
@web-padawan web-padawan removed the request for review from vursen April 7, 2026 13:55
@web-padawan web-padawan merged commit 7e0c152 into main Apr 7, 2026
10 checks passed
@web-padawan web-padawan deleted the fix/mdl-focus-visible branch April 7, 2026 13:56
web-padawan added a commit that referenced this pull request Apr 8, 2026
)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants