fix: prevent split-layout from overflowing parent flex container#11462
Merged
DiegoCardoso merged 1 commit intomainfrom Apr 9, 2026
Merged
fix: prevent split-layout from overflowing parent flex container#11462DiegoCardoso merged 1 commit intomainfrom
DiegoCardoso merged 1 commit intomainfrom
Conversation
Add min-height: 0 to the :host rule so that the split-layout, when used as a flex item, can shrink below its content's natural height. Without this, a grid inside a horizontal split-layout in a flex column parent expands to full content height instead of scrolling internally. Fixes: #11362
|
jouni
approved these changes
Apr 9, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
) ## Description Add `min-height: 0` to the `:host` rule so that the `split-layout`, when used as a flex item, can shrink below its content's natural height. Without this, a grid inside a horizontal `split-layout` in a flex column parent expands to full content height instead of scrolling internally. Fixes #11362 ## Type of change - Bugfix
DiegoCardoso
added a commit
that referenced
this pull request
Apr 9, 2026
) (CP: 25.1) (#11471) This PR cherry-picks changes from the original PR #11462 to branch 25.1. --- #### Original PR description > ## Description > > Add `min-height: 0` to the `:host` rule so that the `split-layout`, when used as a flex item, can shrink below its content's natural height. Without this, a grid inside a horizontal `split-layout` in a flex column parent expands to full content height instead of scrolling internally. > > Fixes #11362 > > ## Type of change > > - Bugfix > Co-authored-by: Diego Cardoso <diego@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
min-height: 0to the:hostrule so that thesplit-layout, when used as a flex item, can shrink below its content's natural height. Without this, a grid inside a horizontalsplit-layoutin a flex column parent expands to full content height instead of scrolling internally.Fixes #11362
Type of change