fix: use --vaadin-padding-l for vertical and horizontal-layout by default#11474
Merged
web-padawan merged 2 commits intomainfrom Apr 10, 2026
Merged
fix: use --vaadin-padding-l for vertical and horizontal-layout by default#11474web-padawan merged 2 commits intomainfrom
web-padawan merged 2 commits intomainfrom
Conversation
web-padawan
reviewed
Apr 10, 2026
Member
web-padawan
left a comment
web-padawan
left a comment
There was a problem hiding this comment.
I wonder if this should be marked as refactor!: as it's a behavior altering change affecting user apps (e.g. could break their screenshot tests)? Should probably not be picked to 25.1.
Member
Author
|
I was wondering about that. It’s not a huge change (from 12px to 16px) and I would hope it wouldn't break any layouts. It can of course compound with nested layouts. It’s okay to me if this applies only to 25.2 and onwards. |
jouni
force-pushed
the
fix/aura-layout-padding
branch
from
3d6da3b to
ca0ae35
Compare
jouni
force-pushed
the
fix/aura-layout-padding
branch
from
ca0ae35 to
3cf27ff
Compare
|
web-padawan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard-layout uses L-size padding by default.