fix: prevent removing outgoing detail when its slot is reassigned#11485
Merged
fix: prevent removing outgoing detail when its slot is reassigned#11485
Conversation
Check that the outgoing detail's slot is still 'detail-outgoing' before removing it in the replace transition's finally block. This allows _startTransition callers to reassign the outgoing element to a different slot (e.g. 'detail-hidden') to preserve it in the DOM. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sissbruecker
approved these changes
Apr 14, 2026
| ]); | ||
| } finally { | ||
| if (oldDetail) { | ||
| if (oldDetail && oldDetail.slot === 'detail-outgoing') { |
Contributor
There was a problem hiding this comment.
I guess a comment here or in the test couldn't hurt on why this is necessary.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__replaceTransition'sfinallyblock so the outgoing detail element is only removed when its slot is stilldetail-outgoing_startTransitioncallers to reassign the outgoing element to a different slot (e.g.detail-hidden) to preserve it in the DOMThis fixes a JS error that occurred in the React component because the web component removed the outgoing detail element, which should have been removed by React instead – a regression that was introduced by #11437 .