refactor!: rename overlayContainment from "viewport" to "page"#11520
Merged
web-padawan merged 1 commit intomainfrom Apr 20, 2026
Merged
refactor!: rename overlayContainment from "viewport" to "page"#11520web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
web-padawan
changed the title
…o "page" Renames the non-default `overlayContainment` value from `"viewport"` to `"page"` across source, typings, CSS selectors, dev pages, tests, and architecture docs. Visual regression baselines are renamed via git mv so they remain byte-identical. The property name and the default `"layout"` value are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
web-padawan
force-pushed
the
refactor/mdl-page-containment
branch
from
2893b34 to
f80ac38
Compare
|
vursen
approved these changes
Apr 20, 2026
github-merge-queue Bot
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Apr 20, 2026
## Description Follow-up to the web component change vaadin/web-components#11520 ## Type of change - Refactor
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overlayContainmentvalue from"viewport"to"page"invaadin-master-detail-layout— the property name and the default"layout"value are unchanged.ARCHITECTURE.md.*-viewport.pngto*-page.pngviagit mvso the images are byte-identical to the originals.This is a breaking change for callers that set
overlayContainment = 'viewport'; the component is still pre-release so the rename is intentional.Test plan
yarn lint:jsyarn lint:cssyarn lint:typesyarn test --group master-detail-layout(overlay, aria, transitions, split-mode — all pass)yarn test:snapshots --group master-detail-layoutyarn test:base --group master-detail-layout(visual — run locally in Docker)yarn test:lumo --group master-detail-layout(visual — run locally in Docker)yarn test:aura --group master-detail-layout(visual — run locally in Docker)yarn start, open the master-detail-layout dev page, select the renamed "Page" radio option, confirm the overlay is fixed-positioned relative to the browser page.🤖 Generated with Claude Code