fix: remove disabled guard from button Lumo hover styles#11548
Merged
web-padawan merged 1 commit intomainfrom Apr 23, 2026
Merged
fix: remove disabled guard from button Lumo hover styles#11548web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
Align with the item Lumo styles where the :not([disabled]) guard was removed so accessible disabled elements still show hover feedback when the corresponding feature flag is enabled. Disabled buttons without accessibleDisabledButtons have pointer-events: none, so :hover doesn't fire anyway. This also matches :host([active])::before in the same file, which has no guard. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
web-padawan
approved these changes
Apr 23, 2026
web-padawan
pushed a commit
that referenced
this pull request
Apr 23, 2026
web-padawan
pushed a commit
that referenced
this pull request
Apr 23, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
accessibleDisabledButtonsfeature flag was originally implemented, the:not([disabled])guard was left on the button Lumo hover styles, which prevented disabled-but-accessible buttons from showing hover feedback. This removes the guard so hover feedback is consistent with the focusable/hoverable behavior the flag enables. Disabled buttons without the flag havepointer-events: none, so:hoverdoes not fire and the visual stays unchanged.Type of change
🤖 Generated with Claude Code