Skip to content

fix: select date on Today click if today is max date#7516

Merged
sissbruecker merged 1 commit into
mainfrom
fix/today-max-date
Jul 8, 2024
Merged

fix: select date on Today click if today is max date#7516
sissbruecker merged 1 commit into
mainfrom
fix/today-max-date

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #7505

Updated the logic to use "today midnight" for comparing with max. Without this change, the actual time is used and dateAllowed returns false when clicking "Today" button, thus making selecting today in this case impossible.

Type of change

  • Bugfix

@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2024

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @web-padawan and @sissbruecker, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 703939b
error: could not apply 703939b... fix: select date on Today click if today is max date (#7516)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[date-picker] today button does not work if max is today

3 participants