🐛 fix: channel reliability — init errors, enabled flag, typed constants#76
Merged
🐛 fix: channel reliability — init errors, enabled flag, typed constants#76
Conversation
A bad bot token (e.g. Telegram 404) no longer kills the whole server. Each channel now logs a warning and is skipped on init failure, letting the admin panel and other channels start normally.
The Save button lives inside x-show="enabled", so disabling a channel hid the form before the user could click Save. Now the Enable toggle calls saveChannel() immediately so the disabled state is persisted.
Two bugs fixed: - loadChannelConfig now returns nil for disabled channels, so they are skipped at startup (enabled=false was previously ignored) - admin.Server now holds a stop-function registry; updateChannel calls Stop() on the running channel when enabled is set to false via the UI
Added Platform* constants to internal/channel/model.go and replaced all
bare string literals ("telegram", "qq", "feishu", "weixin", "cli") across
channel packages, admin handlers, and gateway.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81d3181d7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
| } | ||
| if !ch.Enabled { | ||
| s.stopChannel(platform) |
There was a problem hiding this comment.
Calling s.stopChannel(platform) when a channel is disabled now invokes each bot's Stop(), but runServer still treats any non-nil Start return as a fatal error. For QQ, Feishu, and Weixin, Stop() cancels an internal context and Start() returns context.Canceled, so disabling one of these channels through /api/channels/{platform} will cause the errgroup to fail and shut down the whole server instead of only stopping that channel.
Useful? React with 👍 / 👎.
📊 Coverage ReportTotal coverage: 44.5% Per-package breakdown |
vaayne
added a commit
that referenced
this pull request
Apr 17, 2026
…ts (#76) * 🐛 fix: degrade channel init errors to warnings so app keeps running A bad bot token (e.g. Telegram 404) no longer kills the whole server. Each channel now logs a warning and is skipped on init failure, letting the admin panel and other channels start normally. * 🐛 fix: auto-save channel enabled state when toggling Enable The Save button lives inside x-show="enabled", so disabling a channel hid the form before the user could click Save. Now the Enable toggle calls saveChannel() immediately so the disabled state is persisted. * 🐛 fix: make channel enabled flag actually stop channels Two bugs fixed: - loadChannelConfig now returns nil for disabled channels, so they are skipped at startup (enabled=false was previously ignored) - admin.Server now holds a stop-function registry; updateChannel calls Stop() on the running channel when enabled is set to false via the UI * ♻️ refactor: replace channel name string literals with typed constants Added Platform* constants to internal/channel/model.go and replaced all bare string literals ("telegram", "qq", "feishu", "weixin", "cli") across channel packages, admin handlers, and gateway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-show="enabled", so disabling a channel couldn't be persisted)enabledflag actually stop running channels —loadChannelConfignow returns nil for disabled channels;admin.Serverholds a stop-function registry and callsStop()when a channel is disabled via the UI"telegram","qq","feishu","weixin","cli") withPlatform*typed constants across channel packages, admin handlers, and gatewayTest plan