✨ feat: inherit Ghostty translucency, blur, and tmux cell opacity#55
✨ feat: inherit Ghostty translucency, blur, and tmux cell opacity#55
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 858dd53f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| backgroundOpacityCells: themeInfo.backgroundOpacityCells, | ||
| palette: themeInfo.palette.map(GhosttyThemeInfo.hexString) | ||
| ) | ||
| guard await cache.shouldApply(payload) else { return } |
There was a problem hiding this comment.
The new early return guard await cache.shouldApply(payload) only compares color payload and ignores which TmuxBackend is being configured, so theme sync is skipped for any second backend that shares the same theme values. This breaks multi-endpoint usage (local + SSH), because WorkspaceManager creates separate tmux backends per endpoint and each server must be configured at least once; with the current cache, the first successful apply can prevent later backends from receiving window-style, status-style, and related options.
Useful? React with 👍 / 👎.
| "Background blur" = "Background blur"; | ||
| "Inherit Ghostty window blur and glass styling for translucent terminal backgrounds." = "Inherit Ghostty window blur and glass styling for translucent terminal backgrounds."; | ||
| "Background blur is only visible when background opacity is below 1.0." = "Background blur is only visible when background opacity is below 1.0."; | ||
| "Apply opacity to colored cells" = "Apply opacity to colored cells"; | ||
| "Let tmux and terminal apps keep translucent backgrounds when they draw colored cells instead of using the default terminal background." = "Let tmux and terminal apps keep translucent backgrounds when they draw colored cells instead of using the default terminal background."; |
There was a problem hiding this comment.
These new localization entries were added under the app target resources, but the new strings are consumed by GhosttySettingsView in MoriUI, where String.localized resolves from MoriUIResourceBundle. Because the keys are missing from Packages/MoriUI/Sources/MoriUI/Resources/*/Localizable.strings, the new blur/opacity labels and descriptions will not localize in the settings UI and will fall back to raw/default text.
Useful? React with 👍 / 👎.
|
Addressed the review feedback in a follow-up commit:
Verification:
Latest commit: |
1 participant
Summary
Changes
GhosttyThemeInfowithbackground-opacity,background-opacity-cells, andbackground-blurNSGlassEffectViewbackground for terminal content when Ghostty glass styles are selectedVerification
swift build -c release --product Morimise run testCloses #46.