✨ feat: add configurable tool path resolution#59
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b82f9e9749
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 012f777af5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Why
Issue #54 reports Mori failing to detect tmux installed in a custom Homebrew prefix like
~/homebrew/bin/tmux. The root problem was broader than tmux availability: different code paths used different PATH assumptions, and local launches for tmux/lazygit/yazi still depended on the app's inherited environment.This change introduces a single resolver with explicit user overrides, common package-manager fallback directories, and PATH lookup, then applies it consistently across tmux detection and local tool launching.
Changes
ToolSettingspersistence inMoriCoreBinaryResolverinMoriCoreTmuxCommandRunnerto use configured paths + shared resolutionSettings > ToolsUI for tmux/lazygit/yazi path overrides/usr/bin/whichValidation
mise run test:coremise run test:tmuxmise run testswift build -c release --product MoriCloses #54