✨ feat: polish MoriRemote iPad and terminal UX#60
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e94b0c9404
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| guard coordinator.state == .disconnected, | ||
| let server = coordinator.activeServer, | ||
| let error = coordinator.lastError, | ||
| selection.selectedServerID == server.id else { |
There was a problem hiding this comment.
The failure panel is gated on selection.selectedServerID == server.id, so if a user starts connecting to server A, then clicks server B in the sidebar while A is still connecting, any error from A is silently dropped in regular-width mode. Because this view has no fallback error banner, the failed attempt leaves no visible feedback, which makes retries/debugging difficult. Consider showing lastError independently of the current selection (or adding a persistent banner).
Useful? React with 👍 / 👎.
Delete DESIGN.md which contained outdated UI/UX design system guidance. Remove references to DESIGN.md from AGENTS.md and remove the design system link from the documentation index. The design guidance in this file has been superseded by the actual implementation patterns in MoriUI and MoriTokens. Keeping it risks confusion with the actual source of truth in the codebase.
1 participant
Summary
DESIGN.md, including denser server rows, flatter sidebars, and cleaner terminal chromeDetails
RegularWidthServerBrowserViewandTerminalSessionHostto separate layout from shell/session ownershipTerminalScreen,ServerListView,TmuxSidebarView, and accessory bar views for compact-vs-regular presentationDESIGN.mdand note MoriRemote’s iPhone/iPad support inREADME.md/README.zh-Hans.mdvendor/ghosttyto the latest upstreammainTesting