Merged
Conversation
Read the live query from the search field's field editor while the palette is active instead of relying on NSTextField.stringValue, which can lag inside the nonactivating panel. This makes ⌘P / ⌘⇧P filtering stable again and avoids stealing arrow/return handling from IME marked text. Fixes #84 Assisted-by: pi:gpt-5.4
Model the command palette as a single mode-aware controller instead of separate full/project-only entry points. Cmd+P and Cmd+Shift+P now share the same toggle path, so pressing the active shortcut dismisses the panel and switching shortcuts swaps modes in place. Assisted-by: pi:gpt-5.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSTextField.stringValuereads inside the floating panel⌘Pand⌘⇧Pon one mode-aware presentation path so both shortcuts switch and dismiss consistentlyTesting
Closes #84