Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tap | 9be5749 | Commit Preview URL Branch Preview URL |
Apr 13 2026, 06:49 AM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6c222ed9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cmd/tap/completion.go
Outdated
| reg, err := script.NewRegistryWithOverride(dir, defaultLocalOverrideDir()) | ||
| if err != nil { | ||
| if errors.Is(err, os.ErrNotExist) { | ||
| return emptyRegistry(), nil | ||
| } |
There was a problem hiding this comment.
Load override scripts when cache directory is absent
When --local-only is not set, a missing cache directory causes script.NewRegistryWithOverride(...) to return os.ErrNotExist, and this branch immediately returns emptyRegistry(). That drops completions from ~/.config/tap/sites even if local override scripts exist (e.g., fresh install before first sync, or cache deleted), so tap site <TAB> shows no local scripts. The fallback should still scan the override directory instead of returning an empty registry.
Useful? React with 👍 / 👎.
Summary
tap completion <shell>commandtap site,tap site run, andtap site infoTesting