docker: drop push-tag trigger; workflow_run is the only canonical path#11
Merged
Conversation
The v0.5.0 release surfaced one more failure mode in docker.yml.
When a v*.*.* tag is pushed, GitHub fires release.yml AND docker.yml
in parallel. The push-tag-triggered docker run starts immediately:
- dist/ doesn't yet contain the wheel (release.yml is still
building it)
- PyPI doesn't yet have the new version (release.yml hasn't
published yet)
Both paths in the Dockerfile fail and the build dies at ~28s.
The workflow_run-triggered run starts AFTER release.yml completes
successfully, downloads the release-dist artifact (now exists),
and installs from the local wheel. That path just shipped
ghcr.io/valani9/vstack:0.5.0 cleanly.
Fix: drop the push-tag trigger entirely. workflow_run is the only
release trigger; workflow_dispatch stays for manual retries.
Eliminates the always-failing parallel run on every release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.5.0 docker.yml shipped GHCR image successfully via the workflow_run path. But the parallel push-tag-triggered run failed at 28s because dist/ + PyPI were both still empty when it started.
Fix: remove the push-tag trigger entirely. workflow_run already covers the release case (and is the only path with the wheel artifact actually available); workflow_dispatch covers manual retries.
Test plan