Refactor prerequisite installation#110
Merged
jdkato merged 1 commit intovale-cli:reviewdogfrom Oct 11, 2023
Merged
Conversation
- Remove `pre.ts` and merge into `main.ts` - Ensures prerequisite installation happens at the same time that vale-action runs, allowing manual installation of ruby/python - Adds additional debugging outputs
Member
|
Thanks! Ideally, I'd like to not have to install these at all since they're only required in certain situations (AsciiDoc and/or reStructuredText files). But since they were included in the Docker-based Action (#105), removing them would have been a breaking change. |
|
@jdkato any chance you're open to creating a new release for this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the usage of the
prelifecycle and instead installs core pip and gem dependencies during the regularmainlifecycle. This allows GitHub action workflows to manually setup python or ruby as necessary as theprelifecycle runs before ALL jobs attempt to execute, and self-hosted runners may not have python or ruby available.Closes #109