fix: Do not run vale if there is no file being modified#49
Merged
jdkato merged 1 commit intovale-cli:masterfrom Dec 14, 2021
Merged
fix: Do not run vale if there is no file being modified#49jdkato merged 1 commit intovale-cli:masterfrom
jdkato merged 1 commit intovale-cli:masterfrom
Conversation
benoitf
force-pushed
the
vale-action-39
branch
from
92f77a3 to
51276da
Compare
benoitf
force-pushed
the
vale-action-39
branch
from
51276da to
1d8e0a9
Compare
Member
|
Thanks -- I'll get a new release out soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #39
When there is no file to check, the list of arguments don't have any files, so vale is failing but as we provide --no-exit flag, it doesn't exit and then, process is waiting for ever.
Here, provides a dumb path to scan so we run vale on empty set of file instead of not having the set of files