Conversation
|
I read a bit about regexpses and looked at the Python example. The current code now tries to include (doc) strings – I added a bit of comments, since for the beginning block I am not sure that works as intended. I put all cases now also in the example file, which. still has to be added to the tests – I have not yet understood how to do that, especially not which output to expect, since I was not yet able to set vale up locally from source.. |
|
Thanks -- setting up an example file is a big help. I can add the tests and then this should be ready for the next release. |
|
Great, if you need help with the file or understanding something on how Julia is formatted usually, let me know. |
|
This should be working in the latest release. Let me know if you run into any issues. |
This PR aims to add Julia support (resolves #729).
I would like to also try to resolve #728 if possible. I added a test file, but I am unsure how to accomplish the string part.
I am also not sure whether my code is correct, since I have never programmed in Go before nor did I have the time to install that, so I just tried to mimic what was there.
For the doc strings, see https://docs.julialang.org/en/v1/manual/documentation/ , maybe it is really just enough to consider strings and multiline strings as text.
The only caveats there are
"$(a) and $a"is a string where the current value ofais interpolated twice (placed in thereraw"``\frac{1}{2}``", where the keywordrawis just used so that I do not have to escape the backslash.(but maybe the two backpacks can be added to some ignore in the
.vale.inilike other Markdown inline math ones as well)Thanks for writing such a nice package, I already use it on a Julia Package (Markdown) Documentation I am writing.