Skip to content

fix!: a typo in the matrix APIs response: algorithm: "timedistancbssematrix"#5000

Merged
kevinkreiser merged 4 commits into
valhalla:masterfrom
CommanderStorm:fix-time-distance-typo
Dec 4, 2024
Merged

fix!: a typo in the matrix APIs response: algorithm: "timedistancbssematrix"#5000
kevinkreiser merged 4 commits into
valhalla:masterfrom
CommanderStorm:fix-time-distance-typo

Conversation

@CommanderStorm

Copy link
Copy Markdown
Contributor

Resolves #4999

Pulled out since this might be a breaking change => might be worth to tag as such and put on the sidelines

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
    ^- not currently documented, but if the update to the matrix api output is merged beforehand, that needs to change: docs: update outputs of the matrix service #4962
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

@CommanderStorm CommanderStorm marked this pull request as draft November 28, 2024 22:28
@CommanderStorm

Copy link
Copy Markdown
Contributor Author

I have not added a Changelog entry as I somewhat expect this to get pushed a few releases until the next MSRV major.
For the changelog:

BREAKING: Fixed a typo in the matrix-APIs responses algorithm field: timedistancbssematrix is now timedistancebssmatrix.

@CommanderStorm CommanderStorm marked this pull request as ready for review November 28, 2024 22:31
@CommanderStorm CommanderStorm changed the title fix: a typo in timedistancbssematrix fix!: a typo in the matrix APIs response: algorithm: "timedistancbssematrix" Nov 28, 2024
@kevinkreiser

kevinkreiser commented Nov 29, 2024

Copy link
Copy Markdown
Member

yeah im not sure if we should do this since it is a breaking change. i know that @xlqian is the primary author and user of this so i guess if he is ok then we can make the change. what do you say @xlqian ?

@kevinkreiser kevinkreiser merged commit 215af9f into valhalla:master Dec 4, 2024
CommanderStorm added a commit to CommanderStorm/valhalla that referenced this pull request Dec 4, 2024
chrstnbwnkl added a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Christian Beiwinkel <chrstn.bwnkl@gmail.com>
ianthetechie pushed a commit to ianthetechie/valhalla that referenced this pull request Feb 7, 2025
…halla#5009)

Co-authored-by: Christian Beiwinkel <chrstn.bwnkl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

algorithms of timedistancebssmatrix are typo-ed

4 participants