Adds 'ignore_construction' flag to allow routing on construction ways#5030
Merged
kevinkreiser merged 19 commits intovalhalla:masterfrom Jan 15, 2025
Merged
Adds 'ignore_construction' flag to allow routing on construction ways#5030kevinkreiser merged 19 commits intovalhalla:masterfrom
kevinkreiser merged 19 commits intovalhalla:masterfrom
Conversation
eikes
force-pushed
the
ignore-construction-flag
branch
from
f82ab05 to
117d2bf
Compare
kevinkreiser
reviewed
Jan 2, 2025
kevinkreiser
reviewed
Jan 2, 2025
kevinkreiser
reviewed
Jan 2, 2025
kevinkreiser
reviewed
Jan 2, 2025
eikes
changed the title
…n ways if ignore_construction
eikes
commented
Jan 6, 2025
kevinkreiser
reviewed
Jan 9, 2025
eikes
force-pushed
the
ignore-construction-flag
branch
from
4e86045 to
c040a5d
Compare
kevinkreiser
previously approved these changes
Jan 15, 2025
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
kevinkreiser
approved these changes
Jan 15, 2025
Contributor
Author
|
🚧 Hooray! 🚧 |
ianthetechie
pushed a commit
to ianthetechie/valhalla
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In the past the ability to "Include roads under construction into the graph" was added: #3455
Currently it is not possible to create routes on ways which have the construction tag though. There is an issue about that, so this PR fixes: #4148
The situation is, that you can include construction ways in the routing graph by enabling the
include_constructionflag in the configuration json before building the graph. You cannot use these ways for routing though as they are explicitly marked as inaccessible in both directions and there is an additional check in the dynamic costing.This PR adds a flag which can be enabled on a request in the costing options to explicitly allow routing on construction ways.
This might not be useful when doing ad-hoc routing, but when planning routes the current construction sites aren't of interest.
Tasklist
If you made changes to the lua files, update the taginfo too.Requirements / Relations