Skip to content

make speed and density factors constexpr#5200

Merged
chrstnbwnkl merged 2 commits intomasterfrom
cb-static-costfactor-arrays
Apr 18, 2025
Merged

make speed and density factors constexpr#5200
chrstnbwnkl merged 2 commits intomasterfrom
cb-static-costfactor-arrays

Conversation

@chrstnbwnkl
Copy link
Member

Issue

These were always initialized in the DynamicCost c-tors but their values never change (not even across costing profiles).

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +28 to +29
* FIXED: multi-edge steps maneuvers [#5191](https://github.com/valhalla/valhalla/pull/5191)
* FIXED: remove start maneuver if route starts on stairs/escalators [#5127](https://github.com/valhalla/valhalla/pull/5127)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those were missing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see :D

@chrstnbwnkl chrstnbwnkl merged commit b35e71a into master Apr 18, 2025
8 of 9 checks passed
@chrstnbwnkl chrstnbwnkl deleted the cb-static-costfactor-arrays branch April 18, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants