fix wrong edge id in bidir a* expansion#5265
Merged
chrstnbwnkl merged 4 commits intomasterfrom May 27, 2025
Merged
Conversation
Member
|
how is it possible we keep finding these. it feels like after all this time it shouldnt happen anymore especially with the "main" algorithm haha |
Member
Author
|
To be fair, you would only go knees deep into this if you suspect there is something wrong with the algorithm, but bidirectional A* is just flawless at this point 😄 I see the dedupe tests are failing because now there are less features with the same ID. To me this seems expected, if we tracked the wrong direction in reverse, there'd be more duplicates |
Member
|
yeah i guess the expansion tracing is "newer" too so its less "settled" |
kevinkreiser
previously approved these changes
May 23, 2025
Member
kevinkreiser
left a comment
kevinkreiser
left a comment
There was a problem hiding this comment.
preemptive ship for when you get the tests updated
kevinkreiser
previously approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
While debugging, I noticed that it was impossible to trace the reverse search expansion, and saw that instead of passing the reverse predecessor, its opposing edge ID was passed (i.e. the one used for traversal only).