remove libgeotiff from Requires in .pc file#5737
Conversation
right, and a few more it seems: spatialite & openssl could be removed too |
chrstnbwnkl
changed the title
| if(ENABLE_DATA_TOOLS) | ||
| list(APPEND REQUIRES spatialite sqlite3 luajit geos openssl) | ||
| endif() | ||
| if(ENABLE_HTTP) | ||
| list(APPEND REQUIRES libcurl) | ||
| endif() |
There was a problem hiding this comment.
That's too much now;) except for spatialite and openssl, they're exposed in our headers and needed to resolve libvalhalla dependencies.
There was a problem hiding this comment.
Urgh your're right. None of these are actually exposed in our headers (anymore, sqlite3 and GEOS are now forward declared and liblua includes were removed from headers in #5466) but downstream projects still need to link against them anyway since they're runtime dependencies.
There was a problem hiding this comment.
I should return to a computer for review😄
chrstnbwnkl
changed the title
|
Okay, back to the beginning... just remove libgeotiff 😄 |
nilsnolde
left a comment
nilsnolde
left a comment
There was a problem hiding this comment.
It's fine to merge if it blocks for some reason. I'll have a look at the .pc again next week, don't think we're really doing the right things there currently (before & after this PR).
2 participants
Since libgeotiff only recently started shipping a package-config file, we shouldn't list it in our pkg-config's
Requiresection. On Ubuntu 24.04 LTS configuration will always fail since pkg-config won't find it unless you provide a dummy .pc file (which is a cumbersome hack).