Skip to content

Fix + prefix handling in to_int/to_float utilities#5746

Merged
SiarheiFedartsou merged 2 commits intomasterfrom
sf-plus-to-int
Dec 2, 2025
Merged

Fix + prefix handling in to_int/to_float utilities#5746
SiarheiFedartsou merged 2 commits intomasterfrom
sf-plus-to-int

Conversation

@SiarheiFedartsou
Copy link
Copy Markdown
Member

@SiarheiFedartsou SiarheiFedartsou commented Nov 29, 2025

Please don't force-push once you received the first review.

Issue

#5704 (comment)

We also could add some special handling for − (not to be confused with -), but not sure we really should: I guess there are many variants of symbols which are similar to minus symbol, but not really minus - tbh not sure if we should handle them all in these utilities - may be it is better to make a part of some Lua preprocessing or something like this.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too
  • If you made changes to a translation file, update transifex too

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review November 30, 2025 07:20
@SiarheiFedartsou SiarheiFedartsou merged commit d2466c2 into master Dec 2, 2025
17 of 18 checks passed
@SiarheiFedartsou SiarheiFedartsou deleted the sf-plus-to-int branch December 2, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants