Fix + prefix handling in to_int/to_float utilities#5746
Merged
SiarheiFedartsou merged 2 commits intomasterfrom Dec 2, 2025
Merged
Fix + prefix handling in to_int/to_float utilities#5746SiarheiFedartsou merged 2 commits intomasterfrom
SiarheiFedartsou merged 2 commits intomasterfrom
Conversation
6 tasks
nilsnolde
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't force-push once you received the first review.
Issue
#5704 (comment)
We also could add some special handling for
− (not to be confused with -), but not sure we really should: I guess there are many variants of symbols which are similar to minus symbol, but not really minus - tbh not sure if we should handle them all in these utilities - may be it is better to make a part of some Lua preprocessing or something like this.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?