Convert popup buttons to labels and remove locate points#359
Merged
nilsnolde merged 3 commits intovalhalla:masterfrom Mar 8, 2026
Merged
Convert popup buttons to labels and remove locate points#359nilsnolde merged 3 commits intovalhalla:masterfrom
nilsnolde merged 3 commits intovalhalla:masterfrom
Conversation
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/359 |
nilsnolde
approved these changes
Mar 8, 2026
Member
nilsnolde
left a comment
There was a problem hiding this comment.
nice, finally a PR removing some code:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactor the map info popup.
Changes -
Closes #356
Note - I investigated the bug and wrote the code for fixes the bug. AI is used in writing test code and debugging the tests failure.
Edit 1:
Fix failing playwright tests caused by the popup refactor. Updated test accordingly. (AI-assisted)