feat: automated boostrapping of coco for a single cluster#12
Merged
butler54 merged 1 commit intovalidatedpatterns:mainfrom Mar 25, 2025
Merged
feat: automated boostrapping of coco for a single cluster#12butler54 merged 1 commit intovalidatedpatterns:mainfrom
butler54 merged 1 commit intovalidatedpatterns:mainfrom
Conversation
mbaldessari
reviewed
Feb 21, 2025
Contributor
mbaldessari
left a comment
mbaldessari
left a comment
There was a problem hiding this comment.
Just a quick drive by review, next time the common/ changes should be their own PRs so it is a lot easier to review?
rhdp/rhdp-cluster-define.py
Outdated
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| typer.run(run) No newline at end of file |
Contributor
There was a problem hiding this comment.
This file could use a run through the black linter (and the addition for checks for the needed env variables before doing anything)
Contributor
|
Btw. if you update common from main today, you'll get a mechanism to debug secret-loading in case of errors. See point 5. here https://validatedpatterns.io/learn/getting-started-secret-management/ |
…on information more than once allowing automation of the install Signed-off-by: Chris Butler <chris.butler@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the coco pattern to minimise the amount of configuration required by end users.
Users, with a cluster provisioned by the OCP installer onto Azure, should only need to provide the following:
Both of have scripts to generate automatically.