feat: externalize the core charts #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butler54
force-pushed
the
external-charts
branch
from
822d1c6 to
655f1fc
Compare
beraldoleal
approved these changes
Nov 27, 2025
Collaborator
beraldoleal
left a comment
beraldoleal
left a comment
There was a problem hiding this comment.
Hi @butler54 thanks for this. I haven't tested, because I'm still having some issues with the sync wave on argocd (vide slack channel). But this LGTM.
All the comments are just nit pick. Trying to have a better git log here, feel free to ignore them for this PR.
| # This default configuration uses a single cluster on azure. | ||
| # It fundamentally violates the separation of duties. | ||
| clusterGroupName: trusted-hub | ||
| clusterGroupName: simple |
Collaborator
There was a problem hiding this comment.
Is this related to externalize? It seems not related. maybe another commit or pr?
Collaborator
Author
There was a problem hiding this comment.
I'll squash this out as we need to keep 'simple' (e..g single cluster as the default'
Signed-off-by: Chris Butler <chris.butler@redhat.com>
butler54
force-pushed
the
external-charts
branch
from
4c4e0f6 to
a36731b
Compare
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Chris Butler <chris.butler@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.