ResourceCustomizations is deprecated

[mbaldessari]

Warning  DeprecationNotice  27m         ResourceCustomizations is deprecated, please use the new formats `ResourceHealthChecks`, `ResourceIgnoreDifferences`, and `Resource
Actions` instead.

oc describe of the cluster-wide argo instance gives the above deprecation notice. We need to fix this (in our common argocd.yaml)

[mbaldessari]

Note that this becomes the reason for OutOfSync of the clusterwide argo app when using more recent gitops installations (seen with gitops-1.10 channel aka argocd 2.8.3)

[mbaldessari]

I am not entirely sure if we're supposed to add it to the argo config object like done here https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/argocd-cm.yaml#L132 or if we just patch the ArgoCD spec.

Additional reading https://www.github.com/redhat-developer/gitops-operator/issues/248

Seems that if we do something like https://www.github.com/IBM/cloudpak-gitops/pull/144/files it won't work, according to https://www.github.com/IBM/cloudpak-gitops/issues/40

We should also check if that healthcheck is still needed with later argo versions?

[mbaldessari]

This patch seems to get us green:

diff --git a/common/clustergroup/templates/plumbing/argocd.yaml b/common/clustergroup/templates/plumbing/argocd.yaml
index 84643644..de83b53c 100644
--- a/common/clustergroup/templates/plumbing/argocd.yaml
+++ b/common/clustergroup/templates/plumbing/argocd.yaml
@@ -14,26 +14,27 @@ metadata:
 spec:
 # Adding health checks to argocd to prevent pvc resources
 # that aren't bound state from blocking deployments
-  resourceCustomizations: |
-    PersistentVolumeClaim:
-      health.lua: |
-        hs = {}
-        if obj.status ~= nil then
-          if obj.status.phase ~= nil then
-            if obj.status.phase == "Pending" then
-              hs.status = "Healthy"
-              hs.message = obj.status.phase
-              return hs
-            elseif obj.status.phase == "Bound" then
-              hs.status = "Healthy"
-              hs.message = obj.status.phase
-              return hs
-            end
+  resourceHealthChecks:
+  - kind: PersistentVolumeClaim
+    check: |
+      hs = {}
+      if obj.status ~= nil then
+        if obj.status.phase ~= nil then
+          if obj.status.phase == "Pending" then
+            hs.status = "Healthy"
+            hs.message = obj.status.phase
+            return hs
+          elseif obj.status.phase == "Bound" then
+            hs.status = "Healthy"
+            hs.message = obj.status.phase
+            return hs
           end
         end
-        hs.status = "Progressing"
-        hs.message = "Waiting for PVC"
-        return hs
+      end
+      hs.status = "Progressing"
+      hs.message = "Waiting for PVC"
+      return hs
+
   applicationInstanceLabelKey: argocd.argoproj.io/instance
   # Not the greatest way to pass git/quay info to sub-applications, but it will do until
   # we can support helmChart with kustomize

See https://github.com/redhat-developer/gitops-operator/blob/master/config/crd/bases/argoproj.io_argocds.yaml#L5675.
It seems to me that with gitops-1.10.0 we're automatically upgraded to v1beta of the ArgoCD CRD and so our old resourceCustomization gets ignored causing OutOfSync. The patch above seems to fix it, but we need to test if it works with our current gitops-1.8