Skip to content

Conversation

@ipbabble
Copy link
Contributor

@ipbabble ipbabble commented Jun 7, 2023

A random review of some of the wording resulted in some cleaner language and additions.

@ipbabble
Copy link
Contributor Author

ipbabble commented Jun 7, 2023

@mbaldessari this and other PRs seem to be heal up on some html links stuff. Can we take a look and see if we can fix the tests?

@ipbabble
Copy link
Contributor Author

ipbabble commented Jun 7, 2023

@abhatt-rh can you check the tests too?

@abhatt-rh
Copy link
Collaborator

@ipbabble I fixed a bunch of htmltest related errors in #275

@ipbabble
Copy link
Contributor Author

@ipbabble I fixed a bunch of htmltest related errors in #275

I reran the tests and they failed @abhatt-rh

@abhatt-rh
Copy link
Collaborator

abhatt-rh commented Jun 22, 2023

@ipbabble I fixed a bunch of htmltest related errors in #275

I reran the tests and they failed @abhatt-rh

Is it correct to assume that you have fetched the latest changes, rebased the PR and then re-running the tests?

Clean up some wording and make other explicit additions.
Removed reference to Skupper so I didn't need to mdoify the dictionary
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ipbabble

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbaldessari
Copy link
Contributor

I rebased it and am merging it

@mbaldessari mbaldessari merged commit d9a90da into main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants