Skip to content

Conversation

@abhatt-rh
Copy link
Collaborator

@abhatt-rh abhatt-rh commented Jul 21, 2023

@abhatt-rh
Copy link
Collaborator Author

@day0hero Kindly review these changes for the medical diagnosis pattern. The Getting Started needs some more work, but that should not hold you from reviewing the other chapters. In the interim, i'll submit changes for the Getting Started chapter.

@day0hero
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

New changes are detected. LGTM label has been removed.

@abhatt-rh
Copy link
Collaborator Author

Merging this one with spellcheck errors. This will be fixed after https://issues.redhat.com/browse/TELCODOCS-1542 is resolved

@abhatt-rh abhatt-rh force-pushed the td-1023 branch 2 times, most recently from d4ab029 to 6a2f536 Compare September 14, 2023 15:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: abhatt-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhatt-rh abhatt-rh added the lgtm label Sep 14, 2023
- removed opendatahub from app list since we no longer deploy it.
- commented out the NOTE about active development

- docs now reflect the correct secret template
- docs now reflect the correct s3 bucket to sync from
- changed all references of `make *` to `./pattern.sh make
  install`
- removed references to `pattern.sh` that no longer exist (make
  predeploy)

These are links that point to the old hybrid-cloud-patterns.io. Now they
point to the new site. This should also fix our failing htmltest jobs.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

New changes are detected. LGTM label has been removed.

@abhatt-rh abhatt-rh added the lgtm label Sep 14, 2023
@abhatt-rh abhatt-rh merged commit 3eb5120 into validatedpatterns:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants