Skip to content

Conversation

@mbaldessari
Copy link
Contributor

The doc was not fully uptodate, relative to the last changes.
Amend that, add a command to show the full json for the vault keys
and surround the storing of the unseal keys sentence in a Note.

Also make sure we use the wrapper when invoking make commands in all
examples

Closes #344

The doc was not fully uptodate, relative to the last changes.
Amend that, add a command to show the full json for the vault keys
and surround the storing of the unseal keys sentence in a Note.

Also make sure we use the wrapper when invoking make commands in all
examples

Closes validatedpatterns#344
@mbaldessari mbaldessari requested a review from abhatt-rh November 6, 2023 18:39
@mbaldessari
Copy link
Contributor Author

This is an automated message:

You can preview this docs PR at http://358.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

@openshift-ci openshift-ci bot added the size/S label Nov 6, 2023
Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits; rest LGTM!

mbaldessari and others added 2 commits November 6, 2023 19:01
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
@mbaldessari mbaldessari merged commit f443531 into validatedpatterns:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clusterGroup.insecureUnsealVaultInsideCluster

2 participants