-
Notifications
You must be signed in to change notification settings - Fork 64
HyperShift Doc Scaffolding #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is an automated message: You can preview this docs PR at http://365.docs-pr.validatedpatterns.io |
Moved most hypershift references to hosted control plane in both attributes configs and the _index.adoc file.
abhatt-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @day0hero, I added a couple of comments for your consideration. These are mostly around adherence to RH/IBM style guides and using product/component names.
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
|
@day0hero: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
|
/lgtm |
|
Will look into the htmltest failures in a separate PR; don't want to hold merge for those |
Adding initial docs