Skip to content

Conversation

@day0hero
Copy link
Contributor

Adding initial docs

@mbaldessari
Copy link
Contributor

This is an automated message:

You can preview this docs PR at http://365.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

@openshift-ci openshift-ci bot added the size/M label Nov 16, 2023
Moved most hypershift references to hosted control plane in both
attributes configs and the _index.adoc file.
Copy link
Collaborator

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @day0hero, I added a couple of comments for your consideration. These are mostly around adherence to RH/IBM style guides and using product/component names.

day0hero and others added 4 commits November 17, 2023 09:32
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@day0hero: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

day0hero and others added 6 commits November 17, 2023 09:35
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
Co-authored-by: Avani Bhatt <avbhatt@redhat.com>
@abhatt-rh
Copy link
Collaborator

/lgtm

@abhatt-rh
Copy link
Collaborator

Will look into the htmltest failures in a separate PR; don't want to hold merge for those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants