-
Notifications
You must be signed in to change notification settings - Fork 14
mbp-951: Add spiffe-vault-client to qtodo app #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@posip-redhat @sabre1041 |
|
Was advocating creation of sidecar container image and push to quay. Slack discussion is on using base python ubi and injecting python code via CM |
sabre1041
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of suggestions
Thanks for the review @sabre1041 ! 🙏 |
a2d0cd9 to
0805ead
Compare
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
sabre1041
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requires #33 to be integrated first
* fix: add ripple ns Signed-off-by: Chris Butler <chris.butler@redhat.com> * feat: enable LE Signed-off-by: Chris Butler <chris.butler@redhat.com> * fix: remove uneeded azure credential code Signed-off-by: Chris Butler <chris.butler@redhat.com> --------- Signed-off-by: Chris Butler <chris.butler@redhat.com>
This PR adds a new sidecar container (
spiffe-vault-client) to qtodo app.A Python script running inside this container will:
jwt.tokengenerated by thespiffe-helpercontainerPerhaps we could build an image instead of creating the script on the fly. This would improve the startup process.
The script can be configured using the following environment variables:
I set up the Chart template to configure these variables using the
values-hub.yamlfile.Here is an example of
spiffe-vault-clientlogs:And this is the result in
qtodoapp container: