Automatic common/ update #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new section for to configure the ArgoCD server to support tls
argocdServer:
route:
tls:
insecureEdgeTerminationPolicy: Redirect
termination: reencrypt
- Default for ArgoCD is to create route with the following:
route: enabled
tls:
insecureEdgeTerminationPolicy: Redirect
termination: passthrough
For more information please refer to https://issues.redhat.com/browse/GITOPS-3918.
- Changed default value for termination
Improve readme for ACM IIB
…irect New global scope argocdServer section for values-global.yaml
We drive this from the patterns-operator-config configmap these days, which makes more sense (it is a clusterwide setting and not really a per pattern one).
Tested with:
❯ helm template operator-install --show-only templates/subscription.yaml --set main.patternsOperator.installPlanApproval=Manual
---
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
name: patterns-operator
namespace: openshift-operators
labels:
operators.coreos.com/patterns-operator.openshift-operators: ""
spec:
channel: fast
installPlanApproval: Manual
name: patterns-operator
source: community-operators
sourceNamespace: openshift-marketplace
❯ helm template operator-install --show-only templates/subscription.yaml --set main.patternsOperator.installPlanApproval=Manual --set main.patternsOperator.startingCSV=1.2.3
---
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
name: patterns-operator
namespace: openshift-operators
labels:
operators.coreos.com/patterns-operator.openshift-operators: ""
spec:
channel: fast
installPlanApproval: Manual
name: patterns-operator
source: community-operators
sourceNamespace: openshift-marketplace
startingCSV: 1.2.3
…stall Drop gitopsspec from pattern's CR
…stall2 Allow customizing the VP operator subscription
Add retries when checking oc version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an automatic process run by mbaldessari on Mon May 6 09:47:45 AM CEST 2024