common automatic update#101
Merged
mbaldessari merged 25 commits intovalidatedpatterns:mainfrom Aug 14, 2023
Merged
Conversation
Contributor
mbaldessari
commented
Aug 14, 2023
mbaldessari
commented
- Add some comments to make if/else and loops clearer
- Add some more comments in applications.yaml
- Add a default for options applicationRetryLimit
- Split out values files to a helper for the acm chart
- Fix up tests
- Fix sa/namespace mixup in vault_spokes_init
- Update local patch
- Update ESO to 0.8.5
- Tweak ESO UBI images
- Upgrade vault-helm to v0.25.0
- Error out from load-iib when INDEX_IMAGES is undefined
- Add docker.io to the whitelisted registries when loading an IIB
- Fix fetching the bundle name when loading an IIB
- Add retries when getting related images
- Fix up common/ tests
Let's improve readability by adding some comments to point out which flow constructs are being ended.
Add some comments to make if/else and loops clearer
Just like we did for the clustergroup chart, let's split the values file list into a dedicated helper. This time since there are no global variables we include it with the current context and not with the '$' context. Tested with MCG: hub and spoke. Correctly observed all the applications running on the spoke.
They changed because we made the list indentation more correct (two extra spaces to the left)
Fix sa/namespace mixup in vault_spokes_init
Also set seccompProfile to null to make things work on OCP 4.10
Tested the ESO upgrade on MCG on both 4.10 and 4.13
Upgrade ESO to v0.8.5
If you call the load-iib target you *must* set INDEX_IMAGES, so
let's error out properly if you do not.
Tested as:
$ unset INDEX_IMAGES
$ make load-iib
make -f common/Makefile load-iib
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
No INDEX_IMAGES defined. Bailing out
$ export INDEX_IMAGES=foo
make load-iib
make -f common/Makefile load-iib
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
PLAY [IIB CI playbook] ***
Error out from load-iib when INDEX_IMAGES is undefined
Upgrade vault-helm to v0.25.0
Medical diagnosis for example uses docker.io/obsidiandynamics/kafdrop:latest which would be denied by policy.
Add docker.io to the whitelisted registries when loading an IIB
The current -w grep command matches channels even when they are
substrings of each other like for the serverless-operator:
$ podman run -i --rm $INDEX_IMAGES alpha list channels /configs "${OPERATOR}" |grep --word-regexp "stable"
serverless-operator stable serverless-operator.v1.30.0
serverless-operator stable-1.29 serverless-operator.v1.29.1
serverless-operator stable-1.30 serverless-operator.v1.30.0
This then causes error when trying to parse the list of images as we
will have multiple images because we break the one image per line
assumption.
Let's fix this by adding spaces around the grep. Ideall we'd use the
opm render command, but the parsing of all the yaml output seems a bit
much to do for this simple use case.
Fix fetching the bundle name when loading an IIB
I have seen it fail once on a system and it worked on the second run, so let's try a couple of times at least before giving up.
Try harder to fetch related images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.