Skip to content

Fix race issue #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fix race issue #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b4fa96
Reverting back to using jobs for fixing race condition. The issue has…
sauagarwa Dec 3, 2024
eef5818
Remove minio dependency
sauagarwa Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/all/llm-serving-service/templates/accelerator-profile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ spec:
tolerations:
- effect: NoSchedule
key: odh-notebook
operator: Exists
operator: Exists
11 changes: 11 additions & 0 deletions charts/all/llm-serving-service/templates/model-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: model-pvc
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 50Gi
volumeMode: Filesystem
15 changes: 8 additions & 7 deletions charts/all/llm-serving-service/templates/serving-service-setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
apiVersion: batch/v1
kind: Job
metadata:
Expand Down Expand Up @@ -46,7 +45,7 @@ spec:
- vllm.entrypoints.openai.api_server
env:
- name: HF_HOME
value: /tmp/hf_home
value: /cache
- name: HF_TOKEN
valueFrom:
secretKeyRef:
Expand Down Expand Up @@ -74,12 +73,13 @@ spec:
- autoSelect: true
name: vLLM
volumes:
- emptyDir:
- name: shm
emptyDir:
medium: Memory
sizeLimit: 2Gi
name: shm
- emptyDir: {}
name: cache
- name: cache
persistentVolumeClaim:
claimName: model-pvc
EOF
cat << EOF | oc apply -f-
apiVersion: serving.kserve.io/v1beta1
Expand Down Expand Up @@ -140,9 +140,10 @@ spec:
echo -n 'openshift-ai initialized';echo
echo -n 'Waiting for dscinitialization/default-dsci to initialize'
echo
oc wait --for=jsonpath='{.status.phase}'=Ready --timeout=600s -n redhat-ods-operator dscinitialization/default-dsci
oc wait --for=jsonpath='{.status.phase}'=Ready --timeout=900s -n redhat-ods-operator dscinitialization/default-dsci
sleep 10
echo -n 'dscinitialization/default-dsci initialized';echo
sleep 120
command:
- /bin/bash
image: image-registry.openshift-image-registry.svc:5000/openshift/tools:latest
Expand Down