Improve the vault pod check#143
Merged
Merged
Conversation
The "Check if the vault pod is present" task (line 19-34) only checks that the Pod resource exists, not that the container is actually running. When the vault container is still in ContainerCreating, the subsequent k8s_exec crashes with a Python ValueError in the k8s_exec module (not a normal ansible failure), which prevents the until retry loop from working. The issue was seen while testing the UI in the secret injection pod Tested on mcg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Check if the vault pod is present" task (line 19-34) only checks
that the Pod resource exists, not that the container is actually
running. When the vault container is still in ContainerCreating, the
subsequent k8s_exec crashes with a Python ValueError in the k8s_exec
module (not a normal ansible failure), which prevents the until retry
loop from working. The issue was seen while testing the UI in the secret
injection pod
Tested on mcg